-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show is gift boolean at order datagrid #4661
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 86e393c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
andrzejewsky
approved these changes
Feb 12, 2024
poulch
added a commit
that referenced
this pull request
Feb 12, 2024
* Update schema * Add checkout option to add button submenu * Update rules * Refactor Condition * Split model to order and catalog * Prepare context * Store condtion type * Support multiple inputs depend on condition type * handleOpenModal * Use rule union * Fix create object from static methods * Fix add new rule * Refactor model * Use BaseRule type in form * Update schema and support field with new names * Filter AddButton submenu by discount type * Filter add button options by discount type * Fix showing conditions * Show saved conditions * Fix catalog conditions * Show base rule summary for order rules * Bump macaw to fix select onChange prop * Use Rule interface, add OrderRule tests * Refactor types * Refactor model * Update scheme, add type to promotion query * Handle discount type field * Bump macaw * Handle range input * Fix order rule label on list * Improve rule summary * Show option label in summary instead of value * Rename models * Refactor rule summary * Refactor rule summary * Comment useEnrichConditions, fix validation schema * Rename hooks, fix tests * Model refactor * Fix ts issues * Fix tests * Refactor to condition value * Fix tests * Remove hooks from context * Keep hooks close to components * Pass RuleForm as child * Last improvments * Refactor rule model * Add changeset * Add discount type component * Add type to initial form values * Bump macaw * Refactor Add button * Update test * Refactor DiscountRule isLoaded * Add type support * Remve useeffect * Add changeset * Extract messages * Init context * Context intro * Remove empty import * Fix tests, fix useDiscountRulesContext imports * Add changeset * Support mutliple condition types * Update label map after rule add * Add sorting * Extract messages * Add changeset * Refactor RuleList * Refactor rule summary to support order conditions * Update test * Add changeset * Update schema * Changeset add * Add test to order rule, update catalog rule test, add test ids * Skeleton * Generate types * Enable discount type at create page * Fix disable type field * Move RewardPrice * Handle gifts * Allow to change discount type at create page * Update validation schema * Show gift errors * Fix reward type slect on change * Improve data transfrmation * Improve validation and messages * Show gift on summary * Fetch gifts labels * Clear gifts and reward value when switch reward type * Some improvemnts, ts fixes, fix validation schema, format gift labels * Update storybook, add mocks, update tests * Add changeset * Extract messages * Format variant optipns label * Add validation when procentage more than 100 * Add empty provider for create page * Range inputs in one row * Fix tests * Redirect ti discount list after submit * Extract messages * Add product name to variant labels * Clear gifts when channel change * Stop send empty conditions, fix validation * Add discount type to datagrid * Fix typo * Send gifts in separate fields * Update types * Refactor useConditionNames * Handle complex condition in promotion rule (#4667) * Update playground query * Update mocks * Update schema * Fix caluclate nested conditions * Prevent predicate send when hasPredicateNestedConditions * Refactor rule reward * Stop navigate on details discount form submit * Improve reward wrapper * Remove semicolon * Use undefined instead of null when no gifts * Show is gift boolean at order datagrid (#4661) * Add is gift to query * Add isGift column to order datagrids * Update fixtures * Add changeset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Related Issues or Documents
Usage Instructions, Screenshots, Recordings
Have you written tests?
[Optional] Description